Add enum entries to InfoGreTun and InfoGreTun6 #174
Conversation
Toorero
force-pushed
the
feature/info_gre_tun
branch
2 times, most recently
from
1a5eea1 to
cf6e5dc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Toorero
force-pushed
the
feature/info_gre_tun
branch
2 times, most recently
from
ae5aa3a to
3bd79ff
Compare
src/link/link_info/gre/gre_tun6.rs
Outdated
| Ttl(u8), | ||
| EncapLimit(u8), | ||
| FlowLabel(u32), | ||
| Flags(u32), // TODO: expose IP6_TNL_F_* flags |
There was a problem hiding this comment.
If todo, then remove it. Otherwise, we have to break the API when we change it bitflags.
There was a problem hiding this comment.
Currently we break the API all the time by substituting generic Netlink attributes with concrete bindings like is done here. Deserializing will now yield the concrete enums instead of the generic Netlink attributes. Breaking API changes are required and currently okay, since we are on major version 0 where the public API can't be considered stable (yet).
I just haven't looked into what the flags are for in the Kernel yet and so I left them out.
I don't really get why we'd want to "remove" todos and why removing them would protect us from breaking the API in the long term if we'd still implement it eventually (since this is what a todos is, if present as a comment as a reminder or not). Additionally there are other places in the code where todos are present that would introduce breaking API changes.
Toorero
force-pushed
the
feature/info_gre_tun
branch
3 times, most recently
from
7630867 to
a66c359
Compare
Signed-off-by: Julius Rüberg <[email protected]>
Toorero
force-pushed
the
feature/info_gre_tun
branch
from
a66c359 to
6dddc0c
Compare
This pull request exposes the most common
IFLA_GRE_*attributes by adding them toInfoGreTunandInfoGreTun6respectively. On that matter I bundled thelink::link_info::gre*modules into a newlink::link_info::gremodule. This was done so I can define used GRE structures shared byInfoGreTunandInfoGreTun6like theIFLA_GRE_*constants.